Skip to content

Conversation

@coolguyzone
Copy link
Contributor

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Nov 3, 2025 9:25pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Nov 3, 2025 9:25pm

Comment on lines +208 to +218
/>
- <LinkWithPlatformIcon
platform="python.aws-lambda"
label="AWS Lambda"
url="/platforms/python/guides/aws-lambda/metrics/"
/>
- <LinkWithPlatformIcon
platform="python.gcp-functions"
label="Google Cloud Functions"
url="/platforms/python/guides/gcp-functions/metrics/"
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: New documentation links are silently redirected to old span-metrics content due to existing redirects.js rules.
Severity: HIGH | Confidence: 0.90

🔍 Detailed Analysis

New documentation links added in docs/product/explore/metrics/getting-started/index.mdx (lines 19-218), such as /platforms/javascript/metrics/ and /platforms/python/guides/django/metrics/, will be intercepted by existing redirect rules in redirects.js. These rules, like { source: '/platforms/javascript/metrics/:path*', destination: '/platforms/javascript/tracing/span-metrics/:path*', }, will silently redirect users to older span-metrics documentation instead of the intended new Metrics product documentation. This occurs when users click on these newly introduced links.

💡 Suggested Fix

Remove or update the conflicting platform-specific metrics redirects in redirects.js, or confirm that the new documentation paths do not collide with existing redirect patterns.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: docs/product/explore/metrics/getting-started/index.mdx#L19-L218

Potential issue: New documentation links added in
`docs/product/explore/metrics/getting-started/index.mdx` (lines 19-218), such as
`/platforms/javascript/metrics/` and `/platforms/python/guides/django/metrics/`, will be
intercepted by existing redirect rules in `redirects.js`. These rules, like `{ source:
'/platforms/javascript/metrics/:path*', destination:
'/platforms/javascript/tracing/span-metrics/:path*', }`, will silently redirect users to
older span-metrics documentation instead of the intended new Metrics product
documentation. This occurs when users click on these newly introduced links.

Did we get this right? 👍 / 👎 to inform future reviews.

@coolguyzone coolguyzone marked this pull request as draft October 31, 2025 22:15
Comment on lines +85 to +96
## Trace-Connected Debugging Flow

Sentry's metrics enable a seamless debugging workflow:

1. **Spot the anomaly**: Notice a spike in your Aggregates view (e.g., `checkout.failed` increased 3x)
2. **Open samples**: Switch to the Samples tab to see individual metric events
3. **Pick a trace**: Click on a sample to open the full trace that produced it
4. **Find the cause**: Examine spans for slow queries, check logs for error messages, view related exceptions
5. **Fix the issue**: With full context in hand, identify and resolve the root cause

Instead of "metric alert → guesswork," debugging becomes a **single flow**: Metric spike → sample → trace → root cause.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Trace-Connected Debugging Flow
Sentry's metrics enable a seamless debugging workflow:
1. **Spot the anomaly**: Notice a spike in your Aggregates view (e.g., `checkout.failed` increased 3x)
2. **Open samples**: Switch to the Samples tab to see individual metric events
3. **Pick a trace**: Click on a sample to open the full trace that produced it
4. **Find the cause**: Examine spans for slow queries, check logs for error messages, view related exceptions
5. **Fix the issue**: With full context in hand, identify and resolve the root cause
Instead of "metric alert → guesswork," debugging becomes a **single flow**: Metric spike → sample → trace → root cause.

I think maybe this section is not needed. It feels like It needs to be an expanded guide. I could see this being replaced with an arcade though.

coolguyzone and others added 2 commits November 3, 2025 13:11
@codecov
Copy link

codecov bot commented Nov 3, 2025

Bundle Report

Changes will increase total bundle size by 2.11kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.48MB 2.11kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 707 bytes 724.7kB 0.1%
../app/platform-redirect/page.js.nft.json 707 bytes 724.62kB 0.1%
../app/sitemap.xml/route.js.nft.json 707 bytes 721.85kB 0.1%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js -6.46kB 1.0kB -86.59%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
static/m9jpldxqiiGBoUEnXGaER/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/m9jpldxqiiGBoUEnXGaER/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/SSKTG2_GAAZxxOOTWZda9/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/SSKTG2_GAAZxxOOTWZda9/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants